Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for pixel clustering on GPU [12.4.x] #38921

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 1, 2022

PR description:

Various fixes for pixel clustering on GPU:

  • when building in debug mode (g++ -DGPU_DEBUG) synchronise only the current stream instead of the whole device after each operation;
  • size the kernel grid based on the correct number of pixel modules for Phase-1;
  • remove obsolete debug statement that does not compile any more.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR.

Backport of #38920 for data taking at HLT.

fwyzard added 3 commits August 1, 2022 17:16
In debug mode, synchronise the current stream instead of the whole
device.
@fwyzard fwyzard changed the title Gpu pixel clustering fixes Various fixes for pixel clustering on GPU [12.4.x] Aug 1, 2022
@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Aug 1, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X.

It involves the following packages:

  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoPixelVertexing/PixelTriplets (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @dgulhan, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 1, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7daea/26571/summary.html
COMMIT: 0c718bd
CMSSW: CMSSW_12_4_X_2022-08-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38921/26571/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676162
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Aug 2, 2022

enable gpu

@jpata
Copy link
Contributor

jpata commented Aug 2, 2022

@cmsbuild please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 2, 2022

urgent

I would like to have this in 12.4.x in order to simplify further debugging

@cmsbuild cmsbuild added the urgent label Aug 2, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7daea/26598/summary.html
COMMIT: 0c718bd
CMSSW: CMSSW_12_4_X_2022-08-02-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38921/26598/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19868
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 2 / 3 workflows

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676174
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Aug 3, 2022

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 3, 2022

+1

@cmsbuild cmsbuild merged commit b99777a into cms-sw:CMSSW_12_4_X Aug 3, 2022
@fwyzard fwyzard deleted the gpu_pixel_clustering_fixes branch October 29, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants